Skip to content
This repository was archived by the owner on Jun 22, 2025. It is now read-only.

Accept dict in eel.start - #32

Closed
ahopkins wants to merge 2 commits into
python-eel:masterfrom
ahopkins:master
Closed

ahopkins wants to merge 2 commits into
python-eel:masterfrom
ahopkins:master

Conversation

@ahopkins

@ahopkins ahopkins commented Mar 8, 2018 •

Copy link
Copy Markdown
Contributor

I did two things in the PR. Let me know if this makes sense for you.

  1. I went through and reformatted some things to make everything PEP8 compliant.
  2. I changed the API for eel.start to accept arguments either in string or dict fashion.
eel.start('/mypage.html', options=options)

Or

mypage = {
    'scheme': 'https',
    'host': 'myhost',
    'port': 8888,
    'page': 'mypage.html'
}
eel.start(mypage, options=options)

This would open the browser to https://myhost:8888/page.html.

If opting for using the dict the defaults for each are as follows:

dict(
    scheme='http',
    host='localhost',
    port=8000,
    page=''
)

@ahopkins ahopkins closed this Mar 8, 2018
@ahopkins

ahopkins commented Mar 8, 2018

Copy link
Copy Markdown
Contributor Author

Closing. Need to make a couple quick changes.

@ChrisKnott

Copy link
Copy Markdown
Collaborator

I like the design though.

I am still abroad without my laptop so haven't had a chance to look at the new issues yet

@ahopkins

Copy link
Copy Markdown
Contributor Author

@ChrisKnott Thanks. I resubmitted it as #33. Great package you have here. I love the design concept. I can see a lot of potential for this project.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants